diff options
| author | Fred Hebert <mononcqc@ferd.ca> | 2019-04-16 20:10:52 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-04-16 20:10:52 -0400 |
| commit | 45aaba22b405b222fd28e46c625748a99a53cff3 (patch) | |
| tree | ba1ef877ddf38a6f5844146e47f4e2f789ab911b /test | |
| parent | 14928247cda69d953e673ed6b5feb6ff679a2dfc (diff) | |
| parent | cb881390dce42dab63f18dba59eddd1e4990b969 (diff) | |
Merge pull request #2035 from ankhers/lint_app_file
Add basic linting for .app file
Diffstat (limited to 'test')
| -rw-r--r-- | test/rebar_compile_SUITE.erl | 20 |
1 files changed, 18 insertions, 2 deletions
diff --git a/test/rebar_compile_SUITE.erl b/test/rebar_compile_SUITE.erl index 0bc3ad0..44f20d7 100644 --- a/test/rebar_compile_SUITE.erl +++ b/test/rebar_compile_SUITE.erl @@ -40,7 +40,9 @@ all() -> always_recompile_when_erl_compiler_options_set, dont_recompile_when_erl_compiler_options_env_does_not_change, recompile_when_erl_compiler_options_env_changes, - rebar_config_os_var]. + rebar_config_os_var, + + app_file_linting]. groups() -> [{basic_app, [], [build_basic_app, paths_basic_app, clean_basic_app]}, @@ -431,7 +433,6 @@ paths_release_apps(Config) -> [Vsn1, Vsn2] = ?config(vsns, Config), {ok, State} = rebar_test_utils:run_and_check(Config, [], ["compile"], return), - code:add_paths(rebar_state:code_paths(State, all_deps)), ok = application:load(list_to_atom(Name1)), ok = application:load(list_to_atom(Name2)), @@ -2312,6 +2313,21 @@ regex_filter_regression(Config) -> {ok, [{file, Expected}]}), ok. +app_file_linting(Config) -> + meck:new(rebar_log, [no_link, passthrough]), + AppDir = ?config(apps, Config), + Name = rebar_test_utils:create_random_name("app_file_linting"), + Vsn = rebar_test_utils:create_random_vsn(), + rebar_test_utils:create_app(AppDir, Name, Vsn, [foo]), + + _ = rebar_test_utils:run_and_check(Config, [], ["compile"], return), + History = meck:history(rebar_log), + Warnings = [{Str, Args} || {_, {rebar_log, log, [warn, Str, Args]}, _} <- History], + + ?assert(none /= proplists:lookup("~p is missing description entry", Warnings)), + ?assert(none /= proplists:lookup("~p is missing kernel from applications list", Warnings)), + ?assert(none /= proplists:lookup("~p is missing stdlib from applications list", Warnings)). + %% %% a copy of lib/parsetools/include/yeccpre.hrl so we can test yrl includefile |