From 39895a78f3508367c85daaf7ae6f749aae368e8d Mon Sep 17 00:00:00 2001 From: Justin Wood Date: Thu, 4 Apr 2019 15:31:20 -0400 Subject: test for app file linting --- test/rebar_compile_SUITE.erl | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) (limited to 'test') diff --git a/test/rebar_compile_SUITE.erl b/test/rebar_compile_SUITE.erl index 0bc3ad0..dfbbc80 100644 --- a/test/rebar_compile_SUITE.erl +++ b/test/rebar_compile_SUITE.erl @@ -40,7 +40,9 @@ all() -> always_recompile_when_erl_compiler_options_set, dont_recompile_when_erl_compiler_options_env_does_not_change, recompile_when_erl_compiler_options_env_changes, - rebar_config_os_var]. + rebar_config_os_var, + + app_file_linting]. groups() -> [{basic_app, [], [build_basic_app, paths_basic_app, clean_basic_app]}, @@ -431,7 +433,6 @@ paths_release_apps(Config) -> [Vsn1, Vsn2] = ?config(vsns, Config), {ok, State} = rebar_test_utils:run_and_check(Config, [], ["compile"], return), - code:add_paths(rebar_state:code_paths(State, all_deps)), ok = application:load(list_to_atom(Name1)), ok = application:load(list_to_atom(Name2)), @@ -2312,6 +2313,23 @@ regex_filter_regression(Config) -> {ok, [{file, Expected}]}), ok. +app_file_linting(Config) -> + meck:new(rebar_log, [no_link, passthrough]), + AppDir = ?config(apps, Config), + Name = rebar_test_utils:create_random_name("app_file_linting"), + Vsn = rebar_test_utils:create_random_vsn(), + rebar_test_utils:create_app(AppDir, Name, Vsn, [foo]), + + _ = rebar_test_utils:run_and_check(Config, [], ["compile"], return), + History = meck:history(rebar_log), + Warnings = [{Str, Args} || {_, {rebar_log, log, [warn, Str, Args]}, _} <- History], + + ct:pal("Warnings Length: ~p", [length(Warnings)]), + ct:pal("Warnings: ~p", [Warnings]), + ?assert(none /= proplists:lookup("~p is missing description entry", Warnings)), + ?assert(none /= proplists:lookup("~p is missing kernel from applications list", Warnings)), + ?assert(none /= proplists:lookup("~p is missing stdlib from applications list", Warnings)). + %% %% a copy of lib/parsetools/include/yeccpre.hrl so we can test yrl includefile -- cgit v1.1 From 60d6e0bb6b422cd1f40ba4ab406b47fb47abacfc Mon Sep 17 00:00:00 2001 From: Justin Wood Date: Tue, 16 Apr 2019 12:57:45 -0400 Subject: Remove debugging --- test/rebar_compile_SUITE.erl | 2 -- 1 file changed, 2 deletions(-) (limited to 'test') diff --git a/test/rebar_compile_SUITE.erl b/test/rebar_compile_SUITE.erl index dfbbc80..44f20d7 100644 --- a/test/rebar_compile_SUITE.erl +++ b/test/rebar_compile_SUITE.erl @@ -2324,8 +2324,6 @@ app_file_linting(Config) -> History = meck:history(rebar_log), Warnings = [{Str, Args} || {_, {rebar_log, log, [warn, Str, Args]}, _} <- History], - ct:pal("Warnings Length: ~p", [length(Warnings)]), - ct:pal("Warnings: ~p", [Warnings]), ?assert(none /= proplists:lookup("~p is missing description entry", Warnings)), ?assert(none /= proplists:lookup("~p is missing kernel from applications list", Warnings)), ?assert(none /= proplists:lookup("~p is missing stdlib from applications list", Warnings)). -- cgit v1.1