1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
|
%% -*- erlang-indent-level: 4;indent-tabs-mode: nil -*-
%% ex: ts=4 sw=4 et
-module(rebar_prv_dialyzer).
-behaviour(provider).
-export([init/1,
do/1,
format_error/1]).
-include("rebar.hrl").
-include_lib("providers/include/providers.hrl").
-define(PROVIDER, dialyzer).
-define(DEPS, [compile]).
-define(PLT_PREFIX, "rebar3").
%% ===================================================================
%% Public API
%% ===================================================================
-spec init(rebar_state:t()) -> {ok, rebar_state:t()}.
init(State) ->
Opts = [{update_plt, $u, "update-plt", boolean, "Enable updating the PLT. Default: true"},
{succ_typings, $s, "succ-typings", boolean, "Enable success typing analysis. Default: true"}],
State1 = rebar_state:add_provider(State, providers:create([{name, ?PROVIDER},
{module, ?MODULE},
{bare, true},
{deps, ?DEPS},
{example, "rebar3 dialyzer"},
{short_desc, short_desc()},
{desc, desc()},
{opts, Opts}])),
{ok, State1}.
desc() ->
short_desc() ++ "\n"
"\n"
"This command will build, and keep up-to-date, a suitable PLT and will use "
"it to carry out success typing analysis on the current project.\n"
"\n"
"The following (optional) configurations can be added to a `proplist` of "
"options `dialyzer` in rebar.config:\n"
"`warnings` - a list of dialyzer warnings\n"
"`get_warnings` - display warnings when altering a PLT file (boolean)\n"
"`plt_extra_apps` - a list of applications to include in the PLT file*\n"
"`plt_location` - the location of the PLT file, `local` to store in the "
"profile's base directory (default) or a custom directory.\n"
"`plt_prefix` - the prefix to the PLT file, defaults to \"rebar3\"**\n"
"`base_plt_apps` - a list of applications to include in the base "
"PLT file***\n"
"`base_plt_location` - the location of base PLT file, `global` to store in "
"$HOME/.cache/rebar3 (default) or a custom directory***\n"
"`base_plt_prefix` - the prefix to the base PLT file, defaults to "
"\"rebar3\"** ***\n"
"\n"
"For example, to warn on unmatched returns: \n"
"{dialyzer, [{warnings, [unmatched_returns]}]}.\n"
"\n"
"*The applications in `dialyzer_base_plt_apps` and any `applications` and "
"`included_applications` listed in their .app files will be added to the "
"list.\n"
"**PLT files are named \"<prefix>_<otp_release>_plt\".\n"
"***The base PLT is a PLT containing the core applications often required "
"for a project's PLT. One base PLT is created per OTP version and "
"stored in `base_plt_location`. A base PLT is used to build project PLTs."
"\n".
short_desc() ->
"Run the Dialyzer analyzer on the project.".
-spec do(rebar_state:t()) -> {ok, rebar_state:t()} | {error, string()}.
do(State) ->
maybe_fix_env(),
?INFO("Dialyzer starting, this may take a while...", []),
code:add_pathsa(rebar_state:code_paths(State, all_deps)),
Plt = get_plt(State),
try
do(State, Plt)
catch
throw:{dialyzer_error, Error} ->
?PRV_ERROR({error_processing_apps, Error});
throw:{dialyzer_warnings, Warnings} ->
?PRV_ERROR({dialyzer_warnings, Warnings});
throw:{unknown_application, _} = Error ->
?PRV_ERROR(Error);
throw:{output_file_error, _, _} = Error ->
?PRV_ERROR(Error)
after
rebar_utils:cleanup_code_path(rebar_state:code_paths(State, default))
end.
%% This is used to workaround dialyzer quirk discussed here
%% https://github.com/rebar/rebar3/pull/489#issuecomment-107953541
%% Dialyzer gets default plt location wrong way by peeking HOME environment
%% variable which usually is not defined on Windows.
maybe_fix_env() ->
{ok, [[HomePath]]} = init:get_argument(home),
os:putenv("DIALYZER_PLT", filename:join(HomePath, ".dialyzer_plt")).
-spec format_error(any()) -> iolist().
format_error({error_processing_apps, Error}) ->
io_lib:format("Error in dialyzing apps: ~s", [Error]);
format_error({dialyzer_warnings, Warnings}) ->
io_lib:format("Warnings occured running dialyzer: ~b", [Warnings]);
format_error({unknown_application, App}) ->
io_lib:format("Could not find application: ~s", [App]);
format_error({output_file_error, File, Error}) ->
Error1 = file:format_error(Error),
io_lib:format("Failed to write to ~s: ~s", [File, Error1]);
format_error(Reason) ->
io_lib:format("~p", [Reason]).
%% Internal functions
get_plt(State) ->
Prefix = get_config(State, plt_prefix, ?PLT_PREFIX),
Name = plt_name(Prefix),
case get_config(State, plt_location, local) of
local ->
BaseDir = rebar_dir:base_dir(State),
filename:join(BaseDir, Name);
Dir ->
filename:join(Dir, Name)
end.
plt_name(Prefix) ->
Prefix ++ "_" ++ rebar_utils:otp_release() ++ "_plt".
do(State, Plt) ->
Output = get_output_file(State),
{PltWarnings, State1} = update_proj_plt(State, Plt, Output),
{Warnings, State2} = succ_typings(State1, Plt, Output),
case PltWarnings + Warnings of
0 ->
{ok, State2};
TotalWarnings ->
?INFO("Warnings written to ~s", [Output]),
throw({dialyzer_warnings, TotalWarnings})
end.
get_output_file(State) ->
BaseDir = rebar_dir:base_dir(State),
Output = filename:join(BaseDir, default_output_file()),
case file:open(Output, [write]) of
{ok, File} ->
ok = file:close(File),
Output;
{error, Reason} ->
throw({output_file_error, Output, Reason})
end.
default_output_file() ->
rebar_utils:otp_release() ++ ".dialyzer_warnings".
update_proj_plt(State, Plt, Output) ->
{Args, _} = rebar_state:command_parsed_args(State),
case proplists:get_value(update_plt, Args) of
false ->
{0, State};
_ ->
do_update_proj_plt(State, Plt, Output)
end.
do_update_proj_plt(State, Plt, Output) ->
?INFO("Updating plt...", []),
Files = proj_plt_files(State),
case read_plt(State, Plt) of
{ok, OldFiles} ->
check_plt(State, Plt, Output, OldFiles, Files);
{error, no_such_file} ->
build_proj_plt(State, Plt, Output, Files)
end.
proj_plt_files(State) ->
BasePltApps = get_config(State, base_plt_apps, default_plt_apps()),
PltApps = get_config(State, plt_extra_apps, []),
Apps = rebar_state:project_apps(State),
DepApps = lists:flatmap(fun rebar_app_info:applications/1, Apps),
get_plt_files(BasePltApps ++ PltApps ++ DepApps, Apps).
default_plt_apps() ->
[erts,
crypto,
kernel,
stdlib].
get_plt_files(DepApps, Apps) ->
?INFO("Resolving files...", []),
get_plt_files(DepApps, Apps, [], []).
get_plt_files([], _, _, Files) ->
Files;
get_plt_files([AppName | DepApps], Apps, PltApps, Files) ->
case lists:member(AppName, PltApps) orelse app_member(AppName, Apps) of
true ->
get_plt_files(DepApps, Apps, PltApps, Files);
false ->
Files2 = app_files(AppName),
?DEBUG("~s files: ~p", [AppName, Files2]),
get_plt_files(DepApps, Apps, [AppName | PltApps], Files2 ++ Files)
end.
app_member(AppName, Apps) ->
case rebar_app_utils:find(ec_cnv:to_binary(AppName), Apps) of
{ok, _App} ->
true;
error ->
false
end.
app_files(AppName) ->
case app_ebin(AppName) of
{ok, EbinDir} ->
ebin_files(EbinDir);
{error, bad_name} ->
throw({unknown_application, AppName})
end.
app_ebin(AppName) ->
case code:lib_dir(AppName, ebin) of
{error, bad_name} = Error ->
Error;
EbinDir ->
check_ebin(EbinDir)
end.
check_ebin(EbinDir) ->
case filelib:is_dir(EbinDir) of
true ->
{ok, EbinDir};
false ->
{error, bad_name}
end.
ebin_files(EbinDir) ->
Wildcard = "*" ++ code:objfile_extension(),
[filename:join(EbinDir, File) ||
File <- filelib:wildcard(Wildcard, EbinDir)].
read_plt(_State, Plt) ->
case dialyzer:plt_info(Plt) of
{ok, Info} ->
Files = proplists:get_value(files, Info, []),
{ok, Files};
{error, no_such_file} = Error ->
Error;
{error, read_error} ->
Error = io_lib:format("Could not read the PLT file ~p", [Plt]),
throw({dialyzer_error, Error})
end.
check_plt(State, Plt, Output, OldList, FilesList) ->
Old = sets:from_list(OldList),
Files = sets:from_list(FilesList),
Remove = sets:to_list(sets:subtract(Old, Files)),
{RemWarnings, State1} = remove_plt(State, Plt, Output, Remove),
Check = sets:to_list(sets:intersection(Files, Old)),
{CheckWarnings, State2} = check_plt(State1, Plt, Output, Check),
Add = sets:to_list(sets:subtract(Files, Old)),
{AddWarnings, State3} = add_plt(State2, Plt, Output, Add),
{RemWarnings + CheckWarnings + AddWarnings, State3}.
remove_plt(State, _Plt, _Output, []) ->
{0, State};
remove_plt(State, Plt, Output, Files) ->
?INFO("Removing ~b files from ~p...", [length(Files), Plt]),
run_plt(State, Plt, Output, plt_remove, Files).
check_plt(State, _Plt, _Output, []) ->
{0, State};
check_plt(State, Plt, Output, Files) ->
?INFO("Checking ~b files in ~p...", [length(Files), Plt]),
run_plt(State, Plt, Output, plt_check, Files).
add_plt(State, _Plt, _Output, []) ->
{0, State};
add_plt(State, Plt, Output, Files) ->
?INFO("Adding ~b files to ~p...", [length(Files), Plt]),
run_plt(State, Plt, Output, plt_add, Files).
run_plt(State, Plt, Output, Analysis, Files) ->
GetWarnings = get_config(State, get_warnings, false),
Opts = [{analysis_type, Analysis},
{get_warnings, GetWarnings},
{init_plt, Plt},
{output_plt, Plt},
{from, byte_code},
{files, Files}],
run_dialyzer(State, Opts, Output).
build_proj_plt(State, Plt, Output, Files) ->
BasePlt = get_base_plt(State),
?INFO("Updating base plt...", []),
BaseFiles = base_plt_files(State),
{BaseWarnings, State1} = update_base_plt(State, BasePlt, Output, BaseFiles),
?INFO("Copying ~p to ~p...", [BasePlt, Plt]),
_ = filelib:ensure_dir(Plt),
case file:copy(BasePlt, Plt) of
{ok, _} ->
{CheckWarnings, State2} = check_plt(State1, Plt, Output, BaseFiles,
Files),
{BaseWarnings + CheckWarnings, State2};
{error, Reason} ->
Error = io_lib:format("Could not copy PLT from ~p to ~p: ~p",
[BasePlt, Plt, file:format_error(Reason)]),
throw({dialyzer_error, Error})
end.
get_base_plt(State) ->
Prefix = get_config(State, base_plt_prefix, ?PLT_PREFIX),
Name = plt_name(Prefix),
case get_config(State, base_plt_location, global) of
global ->
GlobalCacheDir = rebar_dir:global_cache_dir(State),
filename:join(GlobalCacheDir, Name);
Dir ->
filename:join(Dir, Name)
end.
base_plt_files(State) ->
BasePltApps = get_config(State, base_plt_apps, default_plt_apps()),
Apps = rebar_state:project_apps(State),
get_plt_files(BasePltApps, Apps).
update_base_plt(State, BasePlt, Output, BaseFiles) ->
case read_plt(State, BasePlt) of
{ok, OldBaseFiles} ->
check_plt(State, BasePlt, Output, OldBaseFiles, BaseFiles);
{error, no_such_file} ->
_ = filelib:ensure_dir(BasePlt),
build_plt(State, BasePlt, Output, BaseFiles)
end.
build_plt(State, Plt, Output, Files) ->
?INFO("Adding ~b files to ~p...", [length(Files), Plt]),
GetWarnings = get_config(State, get_warnings, false),
Opts = [{analysis_type, plt_build},
{get_warnings, GetWarnings},
{output_plt, Plt},
{files, Files}],
run_dialyzer(State, Opts, Output).
succ_typings(State, Plt, Output) ->
{Args, _} = rebar_state:command_parsed_args(State),
case proplists:get_value(succ_typings, Args) of
false ->
{0, State};
_ ->
Apps = rebar_state:project_apps(State),
succ_typings(State, Plt, Output, Apps)
end.
succ_typings(State, Plt, Output, Apps) ->
?INFO("Doing success typing analysis...", []),
Files = apps_to_files(Apps),
?INFO("Analyzing ~b files with ~p...", [length(Files), Plt]),
Opts = [{analysis_type, succ_typings},
{get_warnings, true},
{from, byte_code},
{files, Files},
{init_plt, Plt}],
run_dialyzer(State, Opts, Output).
apps_to_files(Apps) ->
?INFO("Resolving files...", []),
[File || App <- Apps,
File <- app_to_files(App)].
app_to_files(App) ->
AppName = ec_cnv:to_atom(rebar_app_info:name(App)),
app_files(AppName).
run_dialyzer(State, Opts, Output) ->
%% dialyzer may return callgraph warnings when get_warnings is false
case proplists:get_bool(get_warnings, Opts) of
true ->
WarningsList = get_config(State, warnings, []),
Opts2 = [{warnings, WarningsList},
{check_plt, false} |
Opts],
?DEBUG("Running dialyzer with options: ~p~n", [Opts2]),
Warnings = format_warnings(Output, dialyzer:run(Opts2)),
{Warnings, State};
false ->
Opts2 = [{warnings, no_warnings()},
{check_plt, false} |
Opts],
?DEBUG("Running dialyzer with options: ~p~n", [Opts2]),
dialyzer:run(Opts2),
{0, State}
end.
format_warnings(Output, Warnings) ->
Warnings1 = format_warnings(Warnings),
console_warnings(Warnings1),
file_warnings(Output, Warnings1),
length(Warnings1).
format_warnings(Warnings) ->
[format_warning(Warning) || Warning <- Warnings].
format_warning(Warning) ->
case strip(dialyzer:format_warning(Warning, fullpath)) of
":0: " ++ Unknown ->
Unknown;
Warning1 ->
Warning1
end.
console_warnings(Warnings) ->
_ = [?CONSOLE("~s", [Warning]) || Warning <- Warnings],
ok.
file_warnings(_, []) ->
ok;
file_warnings(Output, Warnings) ->
Warnings1 = [[Warning, $\n] || Warning <- Warnings],
case file:write_file(Output, Warnings1, [append]) of
ok ->
ok;
{error, Reason} ->
throw({output_file_error, Output, Reason})
end.
strip(Warning) ->
string:strip(Warning, right, $\n).
no_warnings() ->
[no_return,
no_unused,
no_improper_lists,
no_fun_app,
no_match,
no_opaque,
no_fail_call,
no_contracts,
no_behaviours,
no_undefined_callbacks].
get_config(State, Key, Default) ->
Config = rebar_state:get(State, dialyzer, []),
proplists:get_value(Key, Config, Default).
|