summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFred Hebert <mononcqc@ferd.ca>2017-10-04 16:21:04 -0400
committerFred Hebert <mononcqc@ferd.ca>2017-10-04 16:21:04 -0400
commit13260ed62126970421d42a2874b100dbf8763ec3 (patch)
treec7ec74ba2f14d3c8bdbd0e3ba28680e21a3eb68f
parent1ef0ed5b2d1fa289575152bb001e6dd3beb963ee (diff)
Add a description in compiled app file if undef
Same default value as used in relx and other environments, but as reported in #979 some tools don't like having no description available.
-rw-r--r--src/rebar_otp_app.erl14
1 files changed, 13 insertions, 1 deletions
diff --git a/src/rebar_otp_app.erl b/src/rebar_otp_app.erl
index ed573f2..1bc33b9 100644
--- a/src/rebar_otp_app.erl
+++ b/src/rebar_otp_app.erl
@@ -117,8 +117,11 @@ preprocess(State, AppInfo, AppSrcFile) ->
%% without a 'registered' value.
A3 = ensure_registered(A2),
+ %% some tools complain if a description is not present.
+ A4 = ensure_description(A3),
+
%% Build the final spec as a string
- Spec = io_lib:format("~p.\n", [{application, AppName, A3}]),
+ Spec = io_lib:format("~p.\n", [{application, AppName, A4}]),
%% Setup file .app filename and write new contents
EbinDir = rebar_app_info:ebin_dir(AppInfo),
@@ -195,6 +198,15 @@ ensure_registered(AppData) ->
AppData
end.
+ensure_description(AppData) ->
+ case lists:keyfind(description, 1, AppData) of
+ false ->
+ %% Required for releases to work.
+ [{description, ""} | AppData];
+ {description, _} ->
+ AppData
+ end.
+
%% In the case of *.app.src we want to give the user the ability to
%% dynamically script the application resource file (think dynamic version
%% string, etc.), in a way similar to what can be done with the rebar