| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
| |
The dynamiclookupcommand member of the _config_ of the server is being
set to NULL when it's copied in confserver_cb(), resulting in dynamic
discovery being done for realms that already have a server.
Patch from Fabian Mauchle.
Addresses RADSECPROXY-69.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
never set clsrvconf->servers=null after it has been properly set up.
set servers->dynfailing=1 instead
Conflicts:
radsecproxy.c
|
| |
|
|
|
| |
Linus' address has changed.
Let's not give spammers Stig's address any more.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
Have connectnonblocking() warn and fail if setting O_NONBLOCK fails.
Have it warn if restoring of flags fail.
coverity: 1449515
|
| |
|
|
| |
coverity: 1449517
|
| |
|
|
| |
coverity: 1449518
|
| |
|
|
|
|
|
| |
buf2radmsg() is never called with rqauth != NULL and secret == NULL
but let's protect against future callers.
coverity: 1449519
|
| |
|
|
| |
coverity: 1449508, 1449522.
|
| |
|
|
| |
coverity: 1449514
|
| |
|
|
|
|
|
| |
Going to errexit doesn't free resconf as that commit claims. It does
free conf though, which is good.
coverity: 1449524
|
| |
|
|
| |
coverity: 1449504
|
| |
|
|
| |
coverity: 1449503
|
| |
|
|
| |
NOTE: Only guarding writes.
|
| | |
|
| |\ |
|
| | | |
|
| | | |
|
| |/
|
|
|
|
| |
This is a long standing, non fatal, bug which was revealed when we
started looking at return values from all calls to setsockopt() in the
coverity branch.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's a chance that incoming (legitimate) connections arrive faster
than what it takes to spawn a new thread and get back to
listen(). Therefore we should ask the stack to queue at least one
entry, i.e. use a backlog value of at least 1. There's arguable also a
chance of more than two concurrent incoming connections, which would
make a case for a backlog value greater than one.
A reasonable high value seems to be 128, which also is what SOMAXCONN
is on many unix systems. In the choice between 1 and 128, an argument
against the higher value is that it may mask the potential problem of
spending a long time serving incoming connections.
Being reasonably confident that radsecproxy is efficient when it comes
to serving incoming connections, by handing them off to a newly
spawned thread, I think that 128 is a fine choice.
Closes RADSECPROXY-72.
|
| |
|
|
| |
This was potentially making things worse.
|
| |
|
|
|
|
|
|
|
|
| |
The dynamiclookupcommand member of the _config_ of the server is being
set to NULL when it's copied in confserver_cb(), resulting in dynamic
discovery being done for realms that already have a server.
Patch from Fabian Mauchle.
Addresses RADSECPROXY-69.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Be aware that use of the DynamicLookupCommand configuration option
still enables code known to be buggy.
|
| |
|
|
|
| |
Next release will be 1.7.1-alpha.
When the 1.7 series becomes stable, the `-alpha' prefix is dropped.
|
| | |
|
| |
|
|
|
|
| |
Writing to 0 seems unwise to me.
Returning NULL will simply move the problem to the callers.
I admit that a better fix would be to fix all the callers.
|
| |
|
|
|
|
| |
Bug reported by Leonhard Knauff.
Closes RADSECPROXY-68.
|
| |
|
|
| |
Patch by Kolbjørn Barmen.
|
| |
|
|
| |
Reported by Luke Benes.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
In practice, sendrq() is called from two functions, radsrv() and
clientwr(), none of which should be able to pass rq->to == NULL.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
The HMAC_ and EVP_MD_ API:s changed in OpenSSL 1.1 in a way that made
it unfeasable to support both older and newer OpenSSL.
Radsecproxy already depends on libnettle for Fticks.
Moving away from libcrypto makes it easier to add support for other
TLS libraries than OpenSSL.
|
| |
|
|
|
|
|
| |
NOTE: pwdcrypt(), msmppencrypt(), msmppdecrypt(), _checkmsgauth(),
_validauth() _createmessageauth() and _radsign() all become slightly
more expensive since we're now allocating and freeing an EVP_MD_CTX or
HMAC_CTX on each invocation.
|
| |
|
|
|
| |
openssl-1.1 uses a new threading API which makes manual locking wrt
openssl not necessary.
|
| |
|
|
|
| |
ASN1_STRING_data was deprecated in openssl-1.1, see
https://www.openssl.org/docs/manmaster/crypto/ASN1_STRING_data.html
|
| |
|
|
|
| |
Not needed as of openssl-1.1, see
https://www.openssl.org/docs/man1.1.0/crypto/ERR_remove_thread_state.html
|
| | |
|
| | |
|