From b0a5f0a52c4bdf6ad6af0de2c8d273898a03e0e5 Mon Sep 17 00:00:00 2001 From: Ernst Widerberg Date: Mon, 25 Apr 2022 10:13:59 +0200 Subject: Refactor out utility function --- src/components/ListItem.js | 12 +++--------- src/components/ScanDetail.js | 15 +++------------ src/util.js | 5 +++++ 3 files changed, 11 insertions(+), 21 deletions(-) create mode 100644 src/util.js (limited to 'src') diff --git a/src/components/ListItem.js b/src/components/ListItem.js index 2951c48..dcafe24 100644 --- a/src/components/ListItem.js +++ b/src/components/ListItem.js @@ -3,6 +3,8 @@ import React from "react"; import Button from "@mui/material/Button"; import Card from "@mui/material/Card"; +import { resultClassName } from "../util"; + class ListItem extends React.Component { render() { return ( @@ -26,15 +28,7 @@ class ListItem extends React.Component { {this.props.system_name} { - if (this.props.vulnerable) return " vulnerable"; - else if (this.props.investigation_needed) - return " investigation_needed"; - else return ""; - })() - } + className={resultClassName(this.props)} variant="outlined" > {this.props.display_name} diff --git a/src/components/ScanDetail.js b/src/components/ScanDetail.js index 34e7a12..9cf4740 100644 --- a/src/components/ScanDetail.js +++ b/src/components/ScanDetail.js @@ -7,6 +7,8 @@ import Tooltip from "@mui/material/Tooltip"; import InfoOutlinedIcon from "@mui/icons-material/InfoOutlined"; +import { resultClassName } from "../util"; + class ScanDetail extends React.Component { render() { return ( @@ -126,18 +128,7 @@ function CustomElement(props) { function Result(props) { return (
- { - if (props.vulnerable) return " vulnerable"; - else if (props.investigation_needed) - return " investigation_needed"; - else return ""; - })() - } - variant="outlined" - > + {props.display_name} {props.description && ( diff --git a/src/util.js b/src/util.js new file mode 100644 index 0000000..d7dac8a --- /dev/null +++ b/src/util.js @@ -0,0 +1,5 @@ +export function resultClassName(props) { + if (props.vulnerable) return "result vulnerable"; + else if (props.investigation_needed) return "result investigation_needed"; + else return "result"; +} -- cgit v1.1