From 77a0eb6fe4dca909c6fe63f00b6793ba759f1a63 Mon Sep 17 00:00:00 2001
From: Tuncer Ayaz <tuncer.ayaz@gmail.com>
Date: Mon, 5 Nov 2012 20:08:48 +0100
Subject: Fix #56 (always-on recursion)

Always-on recursive application of all rebar commands causes too many
issues. Recursive application is required for:
1. dealing with dependencies: get-deps, update-deps, and compile of deps
   right after get-deps or update-deps
2. projects with a riak-like apps/ project structure and dev process

The vast majority of projects are not structured like riak. Therefore,
moving forward it's best to (by default) restrict recursive behavior to
dealing with deps. This commit does that and also adds command line and
rebar.config options for controlling or configuring recursion. Also, we
introduce two meta commands: prepare-deps (equivalent to rebar -r
get-deps compile) and refresh-deps (equivalent to rebar -r update-deps
compile). riak-like projects can extend the list of recursive commands
(to include 'eunit' and 'compile') by adding
{recursive_cmds, [eunit, compile]} to rebar.config.
---
 src/rebar.erl | 27 ++++++++++++++++++++-------
 1 file changed, 20 insertions(+), 7 deletions(-)

(limited to 'src/rebar.erl')

diff --git a/src/rebar.erl b/src/rebar.erl
index 36a7b36..618cce8 100644
--- a/src/rebar.erl
+++ b/src/rebar.erl
@@ -206,8 +206,10 @@ help() ->
        "  ~p~n"
        "  ~p~n"
        "  ~p~n"
+       "  ~p~n"
        "  ~p~n",
        [
+        {recursive_cmds, []},
         {lib_dirs, []},
         {sub_dirs, ["dir1", "dir2"]},
         {plugins, [plugin1, plugin2]},
@@ -254,19 +256,23 @@ save_options(Config, {Options, NonOptArgs}) ->
     Config3 = rebar_config:set_xconf(Config2, keep_going,
                                      proplists:get_bool(keep_going, Options)),
 
+    %% Setup flag to enable recursive application of commands
+    Config4 = rebar_config:set_xconf(Config3, recursive,
+                                     proplists:get_bool(recursive, Options)),
+
     %% Set global variables based on getopt options
-    Config4 = set_global_flag(Config3, Options, force),
-    Config5 = case proplists:get_value(jobs, Options, ?DEFAULT_JOBS) of
+    Config5 = set_global_flag(Config4, Options, force),
+    Config6 = case proplists:get_value(jobs, Options, ?DEFAULT_JOBS) of
                   ?DEFAULT_JOBS ->
-                      Config4;
+                      Config5;
                   Jobs ->
-                      rebar_config:set_global(Config4, jobs, Jobs)
+                      rebar_config:set_global(Config5, jobs, Jobs)
               end,
 
     %% Filter all the flags (i.e. strings of form key=value) from the
     %% command line arguments. What's left will be the commands to run.
-    {Config6, RawCmds} = filter_flags(Config5, NonOptArgs, []),
-    {Config6, unabbreviate_command_names(RawCmds)}.
+    {Config7, RawCmds} = filter_flags(Config6, NonOptArgs, []),
+    {Config7, unabbreviate_command_names(RawCmds)}.
 
 %%
 %% set log level based on getopt option
@@ -358,6 +364,9 @@ list-templates                           List available templates
 
 doc                                      Generate Erlang program documentation
 
+prepare-deps                             Run 'rebar -r get-deps compile'
+refresh-deps                             Run 'rebar -r update-deps compile'
+
 check-deps                               Display to be fetched dependencies
 get-deps                                 Fetch dependencies
 update-deps                              Update fetched dependencies
@@ -420,7 +429,9 @@ option_spec_list() ->
      {config,   $C, "config",   string,    "Rebar config file to use"},
      {profile,  $p, "profile",  undefined, "Profile this run of rebar"},
      {keep_going, $k, "keep-going", undefined,
-      "Keep running after a command fails"}
+      "Keep running after a command fails"},
+     {recursive, $r, "recursive", boolean,
+      "Apply commands to subdirs and dependencies"}
     ].
 
 %%
@@ -469,7 +480,9 @@ command_names() ->
      "help",
      "list-deps",
      "list-templates",
+     "prepare-deps",
      "qc",
+     "refresh-deps",
      "update-deps",
      "overlay",
      "shell",
-- 
cgit v1.1