From 81483f9f5dc12adafc45fc549f536c1e18165f99 Mon Sep 17 00:00:00 2001 From: Tuncer Ayaz Date: Mon, 25 Jan 2016 22:52:57 +0100 Subject: bash completion: fix error introduced in cf66dfd6 cf66dfd6ba introduced a syntax error in the modified lopts string. Without the fix, you'll provoke a shell error when trying to complete `rebar3 ct --`. --- priv/shell-completion/bash/rebar3 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'priv') diff --git a/priv/shell-completion/bash/rebar3 b/priv/shell-completion/bash/rebar3 index 771297c..49427ef 100644 --- a/priv/shell-completion/bash/rebar3 +++ b/priv/shell-completion/bash/rebar3 @@ -74,8 +74,8 @@ _rebar3() --multiply_timetraps \ --scale_timetraps \ --create_priv_dir \ - --verbose" \ - --auto_compile + --verbose \ + --auto_compile" elif [[ ${prev} == deps ]] ; then : elif [[ ${prev} == dialyzer ]] ; then -- cgit v1.1 From 7c9dd6c1ecd298a6b207342f05b386adb9c412e5 Mon Sep 17 00:00:00 2001 From: Tuncer Ayaz Date: Mon, 25 Jan 2016 22:54:09 +0100 Subject: bash completion: prevent future mistakes in lopts To prevent future mistakes like the broken string introduced in cf66dfd6ba, put opening and closing " on separate lines in each multi-line lopts string. This also allows for cleaner (smaller) diffs when removing/adding a flag. --- priv/shell-completion/bash/rebar3 | 36 ++++++++++++++++++++++++------------ 1 file changed, 24 insertions(+), 12 deletions(-) (limited to 'priv') diff --git a/priv/shell-completion/bash/rebar3 b/priv/shell-completion/bash/rebar3 index 49427ef..3cd3cd7 100644 --- a/priv/shell-completion/bash/rebar3 +++ b/priv/shell-completion/bash/rebar3 @@ -10,7 +10,8 @@ _rebar3() if [[ ${prev} == rebar3 ]] ; then sopts="-h -v" lopts="--help --version" - cmdsnvars="as \ + cmdsnvars=" \ + as \ clean \ compile \ cover \ @@ -37,7 +38,8 @@ _rebar3() update \ upgrade \ version \ - xref" + xref \ + " elif [[ ${prev} == as ]] ; then : elif [[ ${prev} == clean ]] ; then @@ -50,7 +52,8 @@ _rebar3() lopts="--reset --verbose" elif [[ ${prev} == ct ]] ; then sopts="-c -v" - lopts="--dir \ + lopts=" \ + --dir \ --suite \ --group \ --case \ @@ -75,7 +78,8 @@ _rebar3() --scale_timetraps \ --create_priv_dir \ --verbose \ - --auto_compile" + --auto_compile \ + " elif [[ ${prev} == deps ]] ; then : elif [[ ${prev} == dialyzer ]] ; then @@ -97,7 +101,8 @@ _rebar3() lopts="--force" elif [[ ${prev} == path ]] ; then sopts="-s" - lopts="--app \ + lopts=" \ + --app \ --base \ --bin \ --ebin \ @@ -105,14 +110,16 @@ _rebar3() --priv \ --separator \ --src \ - --rel" + --rel \ + " elif [[ ${prev} == pkgs ]] ; then : elif [[ ${prev} == plugins ]] ; then : elif [[ ${prev} == release ]] ; then sopts="-n -v -g -u -o -h -l -p -V -d -i -a -c -r" - lopts="--relname \ + lopts=" \ + --relname \ --relvsn \ --goal \ --upfrom \ @@ -131,10 +138,12 @@ _rebar3() --sys_config \ --system_libs \ --version \ - --root" + --root \ + " elif [[ ${prev} == relup ]] ; then sopts="-n -v -g -u -o -h -l -p -V -d -i -a -c -r" - lopts="--relname \ + lopts=" \ + --relname \ --relvsn \ --goal \ --upfrom \ @@ -153,14 +162,16 @@ _rebar3() --sys_config \ --system_libs \ --version \ - --root" + --root \ + " elif [[ ${prev} == report ]] ; then : elif [[ ${prev} == shell ]] ; then : elif [[ ${prev} == tar ]] ; then sopts="-n -v -g -u -o -h -l -p -V -d -i -a -c -r" - lopts="--relname \ + lopts=" \ + --relname \ --relvsn \ --goal \ --upfrom \ @@ -179,7 +190,8 @@ _rebar3() --sys_config \ --system_libs \ --version \ - --root" + --root \ + " elif [[ ${prev} == tree ]] ; then sopts="-v" lopts="--verbose" -- cgit v1.1