From 04f63ff53c554afbd42714038a6c8b727266c2f0 Mon Sep 17 00:00:00 2001 From: alisdair sullivan Date: Sat, 16 May 2015 23:14:38 -0700 Subject: remove use of `code:load_abs/1` in favor of `beam_lib:chunks/2` to avoid repeated loading and unloading of modules --- src/rebar_erlc_compiler.erl | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/rebar_erlc_compiler.erl b/src/rebar_erlc_compiler.erl index 8fe03b7..684fedb 100644 --- a/src/rebar_erlc_compiler.erl +++ b/src/rebar_erlc_compiler.erl @@ -227,14 +227,20 @@ maybe_rm_beam_and_edge(G, OutDir, Source) -> digraph:del_vertex(G, Source) end. -opts_changed(Opts, ObjectFile) -> - case code:load_abs(ObjectFile) of - {module, Mod} -> - Compile = Mod:module_info(compile), - lists:sort(Opts) =/= lists:sort(proplists:get_value(options, - Compile, - [])); - {error, _} -> true +opts_changed(NewOpts, Target) -> + case compile_info(Target) of + {ok, Opts} -> lists:sort(Opts) =/= lists:sort(NewOpts); + _ -> true + end. + +compile_info(Target) -> + case beam_lib:chunks(Target, [compile_info]) of + {ok, {_mod, Chunks}} -> + CompileInfo = proplists:get_value(compile_info, Chunks, []), + {ok, proplists:get_value(options, CompileInfo, [])}; + {error, beam_lib, Reason} -> + ?WARN("Couldn't read debug info from ~p for reason: ~p", [Target, Reason]), + {error, Reason} end. erlcinfo_file(Dir) -> -- cgit v1.1