From 6d8c544ecd0440ab959220f1cb121bb4ffa8678f Mon Sep 17 00:00:00 2001 From: Rob Ashton Date: Wed, 24 Jul 2019 10:24:34 +0000 Subject: Stick the usort in our termination clause --- src/rebar_compiler_erl.erl | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/src/rebar_compiler_erl.erl b/src/rebar_compiler_erl.erl index da4a1b0..95f3a17 100644 --- a/src/rebar_compiler_erl.erl +++ b/src/rebar_compiler_erl.erl @@ -245,21 +245,20 @@ module_to_erl(Mod) -> atom_to_list(Mod) ++ ".erl". parse_attrs(Fd, Includes, Dir) -> - DupIncludes = case io:parse_erl_form(Fd, "") of - {ok, Form, _Line} -> - case erl_syntax:type(Form) of - attribute -> - NewIncludes = process_attr(Form, Includes, Dir), - parse_attrs(Fd, NewIncludes, Dir); - _ -> - parse_attrs(Fd, Includes, Dir) - end; - {eof, _} -> - Includes; - _Err -> - parse_attrs(Fd, Includes, Dir) - end, - lists:usort(DupIncludes). + case io:parse_erl_form(Fd, "") of + {ok, Form, _Line} -> + case erl_syntax:type(Form) of + attribute -> + NewIncludes = process_attr(Form, Includes, Dir), + parse_attrs(Fd, NewIncludes, Dir); + _ -> + parse_attrs(Fd, Includes, Dir) + end; + {eof, _} -> + lists:usort(Includes); + _Err -> + parse_attrs(Fd, Includes, Dir) + end. process_attr(Form, Includes, Dir) -> AttrName = erl_syntax:atom_value(erl_syntax:attribute_name(Form)), -- cgit v1.1