From 3ed0c5feffb0fea4b8f4e9cfd74472792867eefe Mon Sep 17 00:00:00 2001 From: Fred Hebert Date: Sun, 31 May 2015 00:41:15 +0000 Subject: fix bareness issues - Crashes in providers lib when no providers in a namespace are bare - Making sure bareness matches semantics; i.e. a bare provider is visible, a non-bare provider is hidden. --- rebar.config | 2 +- rebar.lock | 2 +- src/rebar_prv_app_discovery.erl | 2 +- src/rebar_prv_as.erl | 2 +- src/rebar_prv_clean.erl | 2 +- src/rebar_prv_common_test.erl | 2 +- src/rebar_prv_compile.erl | 2 +- src/rebar_prv_cover.erl | 2 +- src/rebar_prv_deps.erl | 2 +- src/rebar_prv_dialyzer.erl | 2 +- src/rebar_prv_do.erl | 2 +- src/rebar_prv_edoc.erl | 2 +- src/rebar_prv_escriptize.erl | 2 +- src/rebar_prv_eunit.erl | 2 +- src/rebar_prv_help.erl | 2 +- src/rebar_prv_install_deps.erl | 2 +- src/rebar_prv_lock.erl | 2 +- src/rebar_prv_new.erl | 2 +- src/rebar_prv_packages.erl | 2 +- src/rebar_prv_release.erl | 2 +- src/rebar_prv_report.erl | 2 +- src/rebar_prv_shell.erl | 2 +- src/rebar_prv_tar.erl | 2 +- src/rebar_prv_unlock.erl | 2 +- src/rebar_prv_update.erl | 2 +- src/rebar_prv_upgrade.erl | 2 +- src/rebar_prv_version.erl | 2 +- src/rebar_prv_xref.erl | 2 +- 28 files changed, 28 insertions(+), 28 deletions(-) diff --git a/rebar.config b/rebar.config index b885002..f1cbd0a 100644 --- a/rebar.config +++ b/rebar.config @@ -7,7 +7,7 @@ {branch, "master"}}}, {providers, "", {git, "https://github.com/tsloughter/providers.git", - {tag, "v1.3.1"}}}, + {tag, "v1.4.0"}}}, {relx, "", {git, "https://github.com/erlware/relx.git", {branch, "master"}}}, diff --git a/rebar.lock b/rebar.lock index b2783d2..20c120f 100644 --- a/rebar.lock +++ b/rebar.lock @@ -4,7 +4,7 @@ 0}, {<<"providers">>, {git,"https://github.com/tsloughter/providers.git", - {ref,"7563ba7e916d5a35972b25b3aa1945ffe0a8e7a5"}}, + {ref,"adc0af0a3f5de2049419a753777686b94f4e2c90"}}, 0}, {<<"mustache">>, {git,"https://github.com/soranoba/mustache.git", diff --git a/src/rebar_prv_app_discovery.erl b/src/rebar_prv_app_discovery.erl index 0e53bb4..ea55e11 100644 --- a/src/rebar_prv_app_discovery.erl +++ b/src/rebar_prv_app_discovery.erl @@ -23,7 +23,7 @@ init(State) -> State1 = rebar_state:add_provider(State, providers:create([{name, ?PROVIDER}, {module, ?MODULE}, - {bare, true}, + {bare, false}, {deps, ?DEPS}, {example, ""}, {short_desc, ""}, diff --git a/src/rebar_prv_as.erl b/src/rebar_prv_as.erl index 64ad951..d8f19d4 100644 --- a/src/rebar_prv_as.erl +++ b/src/rebar_prv_as.erl @@ -22,7 +22,7 @@ init(State) -> State1 = rebar_state:add_provider(State, providers:create([{name, ?PROVIDER}, {module, ?MODULE}, - {bare, false}, + {bare, true}, {deps, ?DEPS}, {example, "rebar3 as ,,... , , ..."}, {short_desc, "Higher order provider for running multiple tasks in a sequence as a certain profiles."}, diff --git a/src/rebar_prv_clean.erl b/src/rebar_prv_clean.erl index 272ac26..68acf36 100644 --- a/src/rebar_prv_clean.erl +++ b/src/rebar_prv_clean.erl @@ -22,7 +22,7 @@ init(State) -> State1 = rebar_state:add_provider(State, providers:create([{name, ?PROVIDER}, {module, ?MODULE}, - {bare, false}, + {bare, true}, {deps, ?DEPS}, {example, "rebar3 clean"}, {short_desc, "Remove compiled beam files from apps."}, diff --git a/src/rebar_prv_common_test.erl b/src/rebar_prv_common_test.erl index af77fa2..8110bc2 100644 --- a/src/rebar_prv_common_test.erl +++ b/src/rebar_prv_common_test.erl @@ -25,7 +25,7 @@ init(State) -> Provider = providers:create([{name, ?PROVIDER}, {module, ?MODULE}, {deps, ?DEPS}, - {bare, false}, + {bare, true}, {example, "rebar3 ct"}, {short_desc, "Run Common Tests."}, {desc, "Run Common Tests."}, diff --git a/src/rebar_prv_compile.erl b/src/rebar_prv_compile.erl index 5a2e379..26d658e 100644 --- a/src/rebar_prv_compile.erl +++ b/src/rebar_prv_compile.erl @@ -21,7 +21,7 @@ init(State) -> State1 = rebar_state:add_provider(State, providers:create([{name, ?PROVIDER}, {module, ?MODULE}, - {bare, false}, + {bare, true}, {deps, ?DEPS}, {example, "rebar3 compile"}, {short_desc, "Compile apps .app.src and .erl files."}, diff --git a/src/rebar_prv_cover.erl b/src/rebar_prv_cover.erl index b38c6b0..6c115b6 100644 --- a/src/rebar_prv_cover.erl +++ b/src/rebar_prv_cover.erl @@ -25,7 +25,7 @@ init(State) -> State1 = rebar_state:add_provider(State, providers:create([{name, ?PROVIDER}, {module, ?MODULE}, - {bare, false}, + {bare, true}, {deps, ?DEPS}, {example, "rebar3 cover"}, {short_desc, "Perform coverage analysis."}, diff --git a/src/rebar_prv_deps.erl b/src/rebar_prv_deps.erl index 5e3b1c5..be81c31 100644 --- a/src/rebar_prv_deps.erl +++ b/src/rebar_prv_deps.erl @@ -18,7 +18,7 @@ init(State) -> providers:create([ {name, ?PROVIDER}, {module, ?MODULE}, - {bare, false}, + {bare, true}, {deps, ?DEPS}, {example, "rebar3 deps"}, {short_desc, "List dependencies"}, diff --git a/src/rebar_prv_dialyzer.erl b/src/rebar_prv_dialyzer.erl index 95529f8..9ca7600 100644 --- a/src/rebar_prv_dialyzer.erl +++ b/src/rebar_prv_dialyzer.erl @@ -25,7 +25,7 @@ init(State) -> {succ_typings, $s, "succ-typings", boolean, "Enable success typing analysis. Default: true"}], State1 = rebar_state:add_provider(State, providers:create([{name, ?PROVIDER}, {module, ?MODULE}, - {bare, false}, + {bare, true}, {deps, ?DEPS}, {example, "rebar3 dialyzer"}, {short_desc, short_desc()}, diff --git a/src/rebar_prv_do.erl b/src/rebar_prv_do.erl index 29ef054..35e85c2 100644 --- a/src/rebar_prv_do.erl +++ b/src/rebar_prv_do.erl @@ -23,7 +23,7 @@ init(State) -> State1 = rebar_state:add_provider(State, providers:create([{name, ?PROVIDER}, {module, ?MODULE}, - {bare, false}, + {bare, true}, {deps, ?DEPS}, {example, "rebar3 do , , ..."}, {short_desc, "Higher order provider for running multiple tasks in a sequence."}, diff --git a/src/rebar_prv_edoc.erl b/src/rebar_prv_edoc.erl index efcfeb5..14df269 100644 --- a/src/rebar_prv_edoc.erl +++ b/src/rebar_prv_edoc.erl @@ -19,7 +19,7 @@ init(State) -> State1 = rebar_state:add_provider(State, providers:create([{name, ?PROVIDER}, {module, ?MODULE}, - {bare, false}, + {bare, true}, {deps, ?DEPS}, {example, "rebar3 edoc"}, {short_desc, "Generate documentation using edoc."}, diff --git a/src/rebar_prv_escriptize.erl b/src/rebar_prv_escriptize.erl index 03332a0..b58800a 100644 --- a/src/rebar_prv_escriptize.erl +++ b/src/rebar_prv_escriptize.erl @@ -47,7 +47,7 @@ init(State) -> Provider = providers:create([ {name, ?PROVIDER}, {module, ?MODULE}, - {bare, false}, + {bare, true}, {deps, ?DEPS}, {example, "rebar3 escriptize"}, {opts, []}, diff --git a/src/rebar_prv_eunit.erl b/src/rebar_prv_eunit.erl index 3ad593d..ce93d33 100644 --- a/src/rebar_prv_eunit.erl +++ b/src/rebar_prv_eunit.erl @@ -24,7 +24,7 @@ init(State) -> Provider = providers:create([{name, ?PROVIDER}, {module, ?MODULE}, {deps, ?DEPS}, - {bare, false}, + {bare, true}, {example, "rebar3 eunit"}, {short_desc, "Run EUnit Tests."}, {desc, "Run EUnit Tests."}, diff --git a/src/rebar_prv_help.erl b/src/rebar_prv_help.erl index be5717f..4bc259a 100644 --- a/src/rebar_prv_help.erl +++ b/src/rebar_prv_help.erl @@ -22,7 +22,7 @@ init(State) -> State1 = rebar_state:add_provider(State, providers:create([{name, ?PROVIDER}, {module, ?MODULE}, - {bare, false}, + {bare, true}, {deps, ?DEPS}, {example, "rebar3 help "}, {short_desc, "Display a list of tasks or help for a given task or subtask."}, diff --git a/src/rebar_prv_install_deps.erl b/src/rebar_prv_install_deps.erl index 80fdbc3..3cdf784 100644 --- a/src/rebar_prv_install_deps.erl +++ b/src/rebar_prv_install_deps.erl @@ -58,7 +58,7 @@ init(State) -> State1 = rebar_state:add_provider(State, providers:create([{name, ?PROVIDER}, {module, ?MODULE}, - {bare, true}, + {bare, false}, {deps, ?DEPS}, {example, undefined}, {short_desc, ""}, diff --git a/src/rebar_prv_lock.erl b/src/rebar_prv_lock.erl index 6fdd743..058846a 100644 --- a/src/rebar_prv_lock.erl +++ b/src/rebar_prv_lock.erl @@ -19,7 +19,7 @@ init(State) -> State1 = rebar_state:add_provider(State, providers:create([{name, ?PROVIDER}, {module, ?MODULE}, - {bare, true}, + {bare, false}, {deps, ?DEPS}, {example, ""}, {short_desc, "Locks dependencies."}, diff --git a/src/rebar_prv_new.erl b/src/rebar_prv_new.erl index 6bc9f53..0528f44 100644 --- a/src/rebar_prv_new.erl +++ b/src/rebar_prv_new.erl @@ -20,7 +20,7 @@ init(State) -> Provider = providers:create([ {name, ?PROVIDER}, {module, ?MODULE}, - {bare, false}, + {bare, true}, {deps, ?DEPS}, {example, "rebar3 new