summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * Update existing tests to use new index structureFred Hebert2016-10-031-1/+4
| |
| * Properly support package aliasing and alt namesFred Hebert2016-09-272-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Aliasing only had a bit of ad-hoc support in rebar3, and various issues have encountered problems related to the package names not mapping properly with the application name. One such issue is https://github.com/erlang/rebar3/issues/1290 The problem has been hard to find because it only impacts transitive dependencies (not top-level ones) of other packages. The root cause for this is that the application name was not being tracked by rebar3's internal index, only the package name and its version were. When a given application was a package app, the data for the application name would be reconstructed from the lock file, but only if it were a top-level app or a dependency of a source application where parsing the lock file is necessary to know what comes next. When a transitive dependency of a package dependency was fetched, we instead read its dependencies directly from the in-memory package index within rebar3. This caused us to only read the package name and version, and lost all information regarding application name. This worked fine for most cases since for the vast majority of packages, the package name matches the app name, but failed for all aliases, which would then be moved to directories that wouldn't match the app name. This in turn broke some aspects of code analysis (in Dialyzer), or other functionality relying on static paths, such as including .hrl files from dependencies. This patch reformats the internal storage format of dependencies to align with the internal one used by rebar3, so that the app name can be carried along with the package name and its version. The fix can only work once `rebar3 update` is called so the index is rebuilt internally, and will the file cached on disk will be incompatible with older rebar3 versions. Currently, the following is not covered: - Tests - Including the package hashes of dependencies so they may match what is in a lock file -- they're being `undefined` instead, which may break some lookups. The previous format did not lend itself to hashing in the same way, and it is possible transitive deps were not being tracked properly, or worked by respecting the current package hierarchy. This will require further analysis For now this commit can allow reviewing and discussion.
* | Merge pull request #1348 from ElectronicRU/masteralisdair sullivan2016-10-133-6/+24
|\ \ | | | | | | | | | | | | Fix sys.config's handling in common_test and otherwise. closes #1289
| * | Some post-review changes:Alexander Sedov2016-10-112-0/+6
| | | | | | | | | | | | | | | - restore path after loading applications, - helpful comments.
| * | Avoid backward-compatibility-breaking changes.Alexander Sedov2016-10-113-13/+15
| | |
| * | Made reading sys.configs consistent with OTP specification.Alexander Sedov2016-10-113-10/+13
| | |
| * | Rereading system configuration sets up persistent options if possible.Alexander Sedov2016-10-111-1/+7
| | |
| * | Made Common Test load the user's applications before slurping config.Alexander Sedov2016-10-111-0/+1
| | |
* | | Merge pull request #1351 from ElectronicRU/fix_stacktraceFred Hebert2016-10-131-2/+3
|\ \ \ | |/ / |/| | Fix stacktrace printing in DEBUG=1 mode. Fixes #1347.
| * | Get stacktrace only once and as soon as possible. Fixes #1347.Alexander Sedov2016-10-131-2/+3
|/ / | | | | | | | | It turns out that pretty-printing uses throw-catch and thus garbages out the stack trace sometimes, so we should get it only once.
* | Merge pull request #1342 from lrascao/feature/OTP19.1Fred Hebert2016-10-051-1/+1
|\ \ | | | | | | Update Travis CI to latest OTP19.1
| * | Update Travis CI to latest OTP19.1Luis Rascao2016-10-051-1/+1
|/ /
* | Merge pull request #1340 from ferd/fix-test-includes-in-compileFred Hebert2016-09-302-10/+84
|\ \ | | | | | | Fix private includes when compiling in test profile
| * | Use all_src_dirs for include pathsFred Hebert2016-09-301-2/+2
| | | | | | | | | | | | Helps cover extra cases.
| * | Fix private includes when compiling in test profileFred Hebert2016-09-302-10/+84
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | When an include file is set in a private path (i.e. src/), the rebar3 compiler would not add them to the {i, Path} params -- only include/ and the project root were being added. This meant that when some extra source directories were added to the compile job, such as test/ when running under the test profile, the private include paths could not be shared with the test module. This patch fixes the issues (and adds tests) for such a specific case by adding all the configured include paths to the {i, Path} erl_opts arguments, yielding successful compile runs.
* | Merge pull request #1339 from inaka/elbrujohalcon.behaviorFred Hebert2016-09-283-2/+5
|\ \ | |/ |/| Add support for behaviors, and not just behaviours
| * Add support for behaviors, and not just behavioursBrujo Benavides2016-09-283-2/+5
|/
* Merge pull request #1335 from erlang/rebar-1331Fred Hebert2016-09-212-8/+37
|\ | | | | allow using an alternate regex to locate test modules during eunit runs
| * allow using an alternate regex to locate test modules during eunit runsalisdair sullivan2016-09-202-8/+37
|/ | | | | | | | {`eunit_test_regex`, Regex}` will use the supplied `Regex` instead of the default to locate tests in test dirs. note this matches only the filename, not the path. the regex is applied to all test dirs, recursively fixes #1331
* Merge pull request #1332 from erlang/rebar-1327Fred Hebert2016-09-201-1/+15
|\ | | | | compile + cover compile prior to analyzing coverdata
| * only compile/cover compile when generating analysisalisdair sullivan2016-09-201-4/+13
| | | | | | | | don't compile when resetting coverdata
| * cover compile prior to calculating coveragealisdair sullivan2016-09-201-1/+6
| | | | | | | | fixes #1327
* | Merge pull request #1333 from erlang/rebar-1328Fred Hebert2016-09-202-3/+118
|\ \ | |/ |/| recompile all files when a parse transform given as an opt needs updating
| * recompile all files when a parse transform given as an opt needs updatingalisdair sullivan2016-09-202-3/+118
|/ | | | | | | | | there's no way to detect which files actually rely on a parse transform passed to the compiler via the options (as opposed to `-compile(..)` so if any parse transforms are in modules that need recompiling just recompile the world fixes #1328
* Merge pull request #1329 from soranoba/update_bbmustacheFred Hebert2016-09-172-3/+3
|\ | | | | update bbmustache 1.3.0
| * update bbmustache 1.3.0soranoba2016-09-172-3/+3
|/
* Merge pull request #1321 from vans163/error_on_load_file_failureFred Hebert2016-09-151-2/+13
|\ | | | | log error if a module failed to load_file, the user should be aware
| * replace error with debugvans1632016-09-031-2/+2
| |
| * log error if a module failed to load_file, the user should be awarevans1632016-09-031-2/+13
| |
* | Merge pull request #1326 from ddeboer/fix-preserve-ownershipFred Hebert2016-09-152-5/+18
|\ \ | | | | | | Prevent crashing when `mv` warns and report warnings to the user instead.
| * | Ignore mv warningsDavid de Boer2016-09-152-5/+18
|/ / | | | | | | | | | | | | In some cases, mv will throw a warning, while still moving the files correctly and returning a 0 return code: "mv: can't preserve ownership of ... Permission denied".
* | Back to semver version post releaseFred Hebert2016-09-021-1/+1
| |
* | Bump to 3.3.1Fred Hebert2016-09-022-2/+2
| |
* | Merge pull request #1320 from vans163/atomic_compile_and_nif_fixalisdair sullivan2016-09-021-2/+32
|\ \ | |/ | | Atomically load changed erlang modules. Non-atomically load nifs. Reference to https://github.com/erlang/rebar3/pull/1317
| * delete purge load_file specific ordervans1632016-09-021-1/+1
| |
| * Make less than R17 compatiblevans1632016-09-011-7/+11
| |
| * comment and spacing fixupvans1632016-09-011-5/+4
| |
| * Update rebar_agent.erlvans1632016-09-011-3/+3
| | | | | | opps. Infinite loop fixed.
| * Update rebar_agent.erlvans1632016-09-011-2/+29
|/ | | | https://github.com/erlang/rebar3/pull/1317 In reference to with support to load erlang code atomically but load nifs non-atomically.
* Merge pull request #1318 from tuncer/conventional-stacktraceFred Hebert2016-08-311-1/+1
|\ | | | | Print stacktrace in a more conventional way
| * Print stacktrace in a more conventional wayTuncer Ayaz2016-08-301-1/+1
| | | | | | | | | | | | Insert a newline before printing the stacktrace so that the term is easier to read and copy. This is a more conventional way to print traces, and is, for instance, the way it's done by make and python.
* | Merge pull request #1316 from erlang/reset_coverdataalisdair sullivan2016-08-272-2/+22
|\ \ | | | | | | reset accumulated coverdata on writing out to disk
| * | r15 proof cover tests``alisdair sullivan2016-08-271-1/+2
| | |
| * | use `cover:analyse(cover:modules())` for tests instead of `cover:analyse()`alisdair sullivan2016-08-271-1/+1
| | | | | | | | | | | | `cover:analyse/0` didn't exist pre-otp18
| * | reset accumulated coverdata on writing out to disk. this preventsalisdair sullivan2016-08-272-2/+21
|/ / | | | | | | | | provider chains like `eunit, ct, proper` from misreporting cover stats from providers later in the sequence
* | Merge pull request #1315 from ferd/fix-hashcheck-noindexFred Hebert2016-08-271-1/+10
|\ \ | | | | | | Fix crash when doing hash check with missing index
| * | Fix crash when doing hash check with missing indexFred Hebert2016-08-271-1/+10
| |/ | | | | | | | | | | | | | | | | | | Specifically, when fetching an application where the expected hash is unknown, the hash is validated from the hex index; when the index is available, the hash is fetched fine and later inserted in the lock file. However, if the index is not available, the call would simply crash. This patch fixes thing so that instead, the index is refreshed before giving up and failing.
* | Merge pull request #1314 from ferd/cover_excl_modsalisdair sullivan2016-08-273-13/+59
|\ \ | |/ |/| Cover excl mods
| * Re-format cover exclusion codeFred Hebert2016-08-271-17/+26
| | | | | | | | | | | | - brings back former error handling and debug messages - keeps the filtering of excluded mods and debug messages - breaks up code into multiple functions and removes nesting
| * Add test suite for cover_excl_mods optionFred Hebert2016-08-271-2/+28
| |