diff options
author | kolla <kolla> | 2009-09-11 13:45:23 +0000 |
---|---|---|
committer | kolla <kolla@e88ac4ed-0b26-0410-9574-a7f39faa03bf> | 2009-09-11 13:45:23 +0000 |
commit | 213cc4a52d49896ae472c223698852fdfefc50aa (patch) | |
tree | 33f331991ec9ee12f1417675aa603002ee28cb6a | |
parent | 2cbec54faf755087a155fec2c493cf44c744adfb (diff) |
Added Stefan's UDP fragmentation fix
git-svn-id: https://svn.testnett.uninett.no/radsecproxy/branches/release-1.3@509 e88ac4ed-0b26-0410-9574-a7f39faa03bf
-rw-r--r-- | radsecproxy.c | 3 | ||||
-rw-r--r-- | util.c | 25 | ||||
-rw-r--r-- | util.h | 1 |
3 files changed, 29 insertions, 0 deletions
diff --git a/radsecproxy.c b/radsecproxy.c index c6dc9ce..702bef6 100644 --- a/radsecproxy.c +++ b/radsecproxy.c @@ -1899,6 +1899,9 @@ void createlistener(uint8_t type, char *arg) { continue; } setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)); + + disable_DF_bit(s, res); + #ifdef IPV6_V6ONLY if (res->ai_family == AF_INET6) setsockopt(s, IPPROTO_IPV6, IPV6_V6ONLY, &on, sizeof(on)); @@ -137,6 +137,28 @@ int connectport(int type, char *host, char *port) { } #endif +/* Disable the "Don't Fragment" bit for UDP sockets. It is set by default, which may cause an "oversized" + RADIUS packet to be discarded on first attempt (due to Path MTU discovery). +*/ + +void disable_DF_bit(int socket, struct addrinfo *res) { + if ((res->ai_family == AF_INET) && (res->ai_socktype == SOCK_DGRAM)) { +#if defined(IP_MTU_DISCOVER) && defined(IP_PMTUDISC_DONT) + /* + * Turn off Path MTU discovery on IPv4/UDP sockets, Linux variant. + */ + int r, action; + debug(DBG_INFO, "disable_DF_bit: disabling DF bit (Linux variant)"); + action = IP_PMTUDISC_DONT; + r = setsockopt(socket, IPPROTO_IP, IP_MTU_DISCOVER, &action, sizeof(action)); + if (r == -1) + debug(DBG_WARN, "Failed to set IP_MTU_DISCOVER"); +#else + debug(DBG_INFO, "Non-Linux platform, unable to unset DF bit for UDP. You should check with tcpdump whether radsecproxy will send its UDP packets with DF bit set!"); +#endif + } +} + int bindtoaddr(struct addrinfo *addrinfo, int family, int reuse, int v6only) { int s, on = 1; struct addrinfo *res; @@ -149,6 +171,9 @@ int bindtoaddr(struct addrinfo *addrinfo, int family, int reuse, int v6only) { debug(DBG_WARN, "bindtoaddr: socket failed"); continue; } + + disable_DF_bit(s,res); + if (reuse) setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)); #ifdef IPV6_V6ONLY @@ -15,6 +15,7 @@ struct sockaddr *addr_copy(struct sockaddr *in); void port_set(struct sockaddr *sa, uint16_t port); void printfchars(char *prefixfmt, char *prefix, char *charfmt, char *chars, int len); +void disable_DF_bit(int socket, struct addrinfo *res); int bindtoaddr(struct addrinfo *addrinfo, int family, int reuse, int v6only); int connecttcp(struct addrinfo *addrinfo, struct addrinfo *src, uint16_t timeout); |