From 6c4ef3f492d88acca931174519b7aa1215cc1a18 Mon Sep 17 00:00:00 2001 From: Pankaj Date: Tue, 5 Jan 2016 09:52:00 +0000 Subject: Avoiding redundant check https://bugs.freedesktop.org/show_bug.cgi?id=93587 --- p11-kit/modules.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'p11-kit') diff --git a/p11-kit/modules.c b/p11-kit/modules.c index acb3707..63baeb1 100644 --- a/p11-kit/modules.c +++ b/p11-kit/modules.c @@ -2326,17 +2326,15 @@ p11_module_load_inlock_reentrant (CK_FUNCTION_LIST *module, } /* If this was newly allocated, add it to the list */ - if (rv == CKR_OK && allocated) { + if (allocated) { if (!p11_dict_set (gl.modules, allocated, allocated) || !p11_dict_set (gl.unmanaged_by_funcs, module, allocated)) return_val_if_reached (CKR_HOST_MEMORY); allocated = NULL; } - if (rv == CKR_OK) { /* WARNING: Reentrancy can occur here */ rv = prepare_module_inlock_reentrant (mod, flags, result); - } free (allocated); } -- cgit v1.1